fix: Addressing a deprecated assumption from NetworkX "links" data #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that this change was introduced in NetworkX 3.4 which drops support for Python versions less than 3.10. We support 3.8 and 3.9, so it looks to me like this will break any installations using those versions. Otherwise, it's 👍🏼 . There are some references to those same values in the tests that I updated, and so the tests now pass for versions that comply with the NetworkX version restrictions. Short of abandoning our support of Python 3.8 and 3.9, maybe we hold this PR until we transition from those? |
|
Excellent point! NetworkX follows: https://scientific-python.org/specs/spec-0000/. I agree that we should hold off on this until we drop support for Python 3.9. |
sdelliot
added
the
Python 3.10
sdelliot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "link" keyword is deprecated for the
node_link_datafunction and will be removed in version NetworkX v3.6. We are switching to the recommended default "edges" instead.See node-link-data for more details.