Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer Mode Implementation SCRUM-1 #86

Merged
merged 23 commits into from
Aug 9, 2024
Merged

Viewer Mode Implementation SCRUM-1 #86

merged 23 commits into from
Aug 9, 2024

Conversation

matherg
Copy link
Collaborator

@matherg matherg commented Aug 9, 2024

Overview

Main dashboard now includes "Viewer" option. Selecting viewer changes all other fields to optional and disables interaction.
When in viewer mode, map displays all riders and drivers. Viewers can input custom start/end locations. Viewers can filter between riders, drivers, and all.

Dynamic map legend implemented for all Roles

Viewers cannot interact with anything aside from view route and favoriting users

Core changes:

  • Viewer Role added to prisma schema
  • Drivers and Riders now exist on separate map layers
  • Update user location util added for viewer mode
  • Logic for only using Azure Auth in Production
  • Removed backend validation for Address and Company Name checks in onboard schema (we have frontend validation)
  • Updated frontend onboarding schema to use conditional checks based on role
  • Favorites query only returns users with correct opposite role

Bug fixes:

  • Clicking the sidebar no longer clears markers
  • Icons are correctly positioned in start/company address selector
  • View route loads only the driver/rider route if the viewer has not chosen an address
  • Favorites query is re-fetched on mount to avoid stale data
  • "About me" is no longer shown as required despite being optional
  • Route is now rendered underneath all other markers

image
image
image
image

matherg and others added 23 commits July 16, 2024 20:07
…ewers until address is chosen, onViewRouteClick now passes user location to children functions
* adding google auth provider

* debugging node_env

* additional debug

* debug database url

* add build commands

* add build env debug

* add nextauth_url to debug

* client side env

* clean up debug

* check for staging

* remove console.log
SCRUM-1 Viewer mode implementation
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nucarpool-46y7 ❌ Failed (Inspect) Aug 9, 2024 3:38pm

Copy link

github-actions bot commented Aug 9, 2024

👋 @matherg
Looks like your PR might contain changes to the schema.prisma file. Please open a deploy request on PlanetScale before merging. If you have any questions, ping @lukejianu on Slack.

Copy link
Collaborator

@sinhaaaryan sinhaaaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested in staging accordingly. For next time in the main changes maybe add more info abt datatypes, such as in file "AddressCombobox.tsx"

@sinhaaaryan sinhaaaryan merged commit 597cbbf into main Aug 9, 2024
5 of 6 checks passed
@sinhaaaryan sinhaaaryan deleted the staging branch August 9, 2024 16:14
@matherg matherg restored the staging branch August 9, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants