Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRUM-47 Basic information about Carpool Group #128

Merged
merged 51 commits into from
Dec 3, 2024
Merged

Conversation

sinhaaaryan
Copy link
Collaborator

  • Changes to Carpool Group page for drivers when group isn't created, and for riders when group is created.
Screenshot 2024-11-20 at 10 29 42 AM ![Screenshot 2024-11-19 at 3 27 58 PM](https://github.com/user-attachments/assets/3a667294-caaf-4617-9246-07214dc19f7b) ![Screenshot 2024-11-19 at 3 24 02 PM](https://github.com/user-attachments/assets/b85b0e5c-0ea6-421c-898e-329c7535fcb5)

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nucarpool-46y7 ❌ Failed (Inspect) Dec 3, 2024 5:21pm

Copy link

👋 @sinhaaaryan
Looks like your PR might contain changes to the schema.prisma file. Please open a deploy request on PlanetScale before merging. If you have any questions, ping @lukejianu on Slack.

@matherg matherg self-requested a review November 21, 2024 19:21
@sinhaaaryan sinhaaaryan changed the base branch from main to staging November 21, 2024 19:34
Copy link
Collaborator

@matherg matherg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Remove scrollbars on group page. Rider side looks good. On group creation or deletion, groupMessage should be set to null or "" in the user table. Currently message persists. When Driver accepts request or sends request, we need to inform them about the group page functionality if groupMessage is "" or null. Sending a request: just add a line in the connect modal. Accepting a request: free to do whatever. Popup or navigate them to group page. (in the sc I had set initial message, accepted request, changed group message, left group, opened group page. group page should not show a message at the end of that flow)

className="w-[150px] rounded-md bg-red-700 py-2 text-white h-full"
onClick={async () => {
await handleMessageSubmit();
onClose();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onClose() doesn't seem to do anything. After pressing submit, there should be some indication of success. (could be loading symbol, popup, or a text display under the text box showing the current message)

Copy link
Collaborator

@matherg matherg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for staging

@sinhaaaryan sinhaaaryan merged commit d5915c5 into staging Dec 3, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants