-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCRUM-47 Basic information about Carpool Group #128
Conversation
sinhaaaryan
commented
Nov 20, 2024
- Changes to Carpool Group page for drivers when group isn't created, and for riders when group is created.

The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
👋 @sinhaaaryan |
…ers in group message, feature working now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove scrollbars on group page. Rider side looks good. On group creation or deletion, groupMessage should be set to null or "" in the user table. Currently message persists. When Driver accepts request or sends request, we need to inform them about the group page functionality if groupMessage is "" or null. Sending a request: just add a line in the connect modal. Accepting a request: free to do whatever. Popup or navigate them to group page. (in the sc I had set initial message, accepted request, changed group message, left group, opened group page. group page should not show a message at the end of that flow)
src/components/GroupPage.tsx
Outdated
className="w-[150px] rounded-md bg-red-700 py-2 text-white h-full" | ||
onClick={async () => { | ||
await handleMessageSubmit(); | ||
onClose(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onClose() doesn't seem to do anything. After pressing submit, there should be some indication of success. (could be loading symbol, popup, or a text display under the text box showing the current message)
FTUE tracking + view route event fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for staging
Admin Dashboard Setup + Permissions
Scrum 125: Block Drivers from changing role when in a group.
…ers in group message, feature working now
…ers in group message, feature working now
…ers in group message, feature working now
…ers in group message, feature working now
…ers in group message, feature working now
…ers in group message, feature working now