Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement signing field groups and assigned groups #273

Merged
merged 12 commits into from
Feb 9, 2025

Conversation

elvincheng3
Copy link
Contributor

@elvincheng3 elvincheng3 commented Feb 5, 2025

Refactor our signature model to implement groups.

There are now field groups and assigned groups. Field groups represent a grouping of fields on a form template to be assigned to a single individual, position, department, or list of individuals. Field groups are found in each form template.

When creating a form instance, new assigned groups are created based off of the field groups on the associated form template. Each assigned group must have one of individual, position, department, or list of individuals who can sign for the group of fields.

Description

Refactors frontend to work with new schema (still has lots of WIP to support different signer types)
Refactors DB model for groups
Refactors seeding script

Motivation and Context

Need to support groups of signatures.

Closes [#]

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mfa-form-automator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 7:22pm

Copy link
Collaborator

@kaiyangzheng kaiyangzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNLGTM!

@@ -18,18 +18,40 @@ enum SignerType {
USER_LIST
}

enum SignatureBoxFieldType {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text box?

Copy link
Collaborator

@kaiyangzheng kaiyangzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elvincheng3 elvincheng3 merged commit aa4dd5f into main Feb 9, 2025
7 checks passed
@elvincheng3 elvincheng3 deleted the implement-signing-groups branch February 9, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants