Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

213 feature UI changes for logon onboarding and create/upload signature #219

Merged
merged 5 commits into from
Dec 1, 2024

Conversation

kaiyangzheng
Copy link
Collaborator

@kaiyangzheng kaiyangzheng commented Dec 1, 2024

Description

  • Match logon onboarding UI to figma design
  • Allow drawn or typed signature and upload to blob storage

Motivation and Context

  • Better looking onboarding page
  • Use real signatures

Closes [#213 ]

How has this been tested?

Screenshots (if appropriate):

image
image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kaiyangzheng kaiyangzheng linked an issue Dec 1, 2024 that may be closed by this pull request
Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mfa-form-automator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 7:19pm

laurenbrissette
laurenbrissette previously approved these changes Dec 1, 2024
Copy link
Contributor

@ahweigl ahweigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIREEEEE 🔥

fontWeight="500"
fontSize="15px"
borderColor={isActive ? activeColor : '#C0C0C0'}
color={isActive ? activeColor : '#63646B'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these colors be constants stored somewhere

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea lets make a ticket for this next sem so we can standardize it for all components

@kaiyangzheng kaiyangzheng merged commit 2e16ece into main Dec 1, 2024
7 checks passed
@kaiyangzheng kaiyangzheng deleted the 213-feature-ui-changes-for-logon-onboarding branch December 1, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] UI changes for logon onboarding
3 participants