Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

205 feature create form template name and description page and add input fields page without the pdf editor component just leave that blank #212

Conversation

laurenbrissette
Copy link
Contributor

Description

Adds pages 2 and 3 of the form template flow.

Page 2 has users input the file name and description. Currently saves in useState but will need to be moved to storage that persists after page. File preview shows blank as file is not currently saved between pages.

Page 3 has users add groups. The white box on this page will hold the pdf editor component.

Motivation and Context

Implements new form template creation pages.

Closes [#205]

How has this been tested?

Tried navigating between pages to complete the form template creation process.

Screenshots (if appropriate):

Screenshot 2024-11-30 at 4 57 40 PM Screenshot 2024-11-30 at 4 58 07 PM Screenshot 2024-11-30 at 4 58 22 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Cannot create form templates until flow is complete and data on each page is stored to persist between pages.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

vercel bot commented Nov 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mfa-form-automator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 10:00pm

Copy link
Collaborator

@kaiyangzheng kaiyangzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure to remove unused imported components next time (for example, lines 1 and 2 in NameAndDescriptionBox.tsx)

@laurenbrissette laurenbrissette merged commit 34acd9a into main Nov 30, 2024
7 checks passed
@kaiyangzheng kaiyangzheng deleted the 205-feature-create-form-template-name-and-description-page-and-add-input-fields-page-without-the-pdf-editor-component-just-leave-that-blank branch November 30, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants