Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

208 feature finish/fix issues with create profile screen #209

Merged
merged 4 commits into from
Nov 30, 2024
Merged

208 feature finish/fix issues with create profile screen #209

merged 4 commits into from
Nov 30, 2024

Conversation

kaiyangzheng
Copy link
Collaborator

Description

  • Use uuid to generate uuids in seed file
  • Add new department in seed file for testing
  • Create findAllInDepartmentName in positions module to look for positions in department we select

Motivation and Context

  • Fix some inconsistencies with select input when completing logon

Closes [#208]

How has this been tested?

Create a new account with Azure login with different department and positions.

Screenshots (if appropriate):

image
image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kaiyangzheng kaiyangzheng linked an issue Nov 30, 2024 that may be closed by this pull request
[FEATURE] Finish up logon and make sure it works #208
Closed
@vercel Vercel
Copy link

vercel bot commented Nov 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mfa-form-automator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 5:13am

@kaiyangzheng kaiyangzheng marked this pull request as ready for review November 30, 2024 04:54
laurenbrissette
laurenbrissette approved these changes Nov 30, 2024
View reviewed changes
Copy link
Contributor

@laurenbrissette laurenbrissette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyangzheng kaiyangzheng merged commit a0d8cd2 into main Nov 30, 2024
7 checks passed
@kaiyangzheng kaiyangzheng deleted the 208-feature-finish-up-logon-and-make-sure-it-works branch November 30, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenbrissette laurenbrissette laurenbrissette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Finish up logon and make sure it works
2 participants
@kaiyangzheng @laurenbrissette