204 feature create form template upload pdf page #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenbrissette
requested review from
kaiyangzheng,
ahweigl,
Gayatri-K26 and
DonnyLe
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kaiyangzheng
requested changes
Nov 28, 2024
| * @param backLink page router will push on click of 'back' | ||
| * @param disabled whether the 'save & continue' button should be activated | ||
| */ | ||
| export const FormTemButtons = ({ |
There was a problem hiding this comment.
Let's name this FormTemplateButtons for clarity.
| import { BlueTriangle, WhiteCheck } from '@web/static/icons'; | ||
| import { useRouter } from 'next/router'; | ||
|
|
||
| export const SideCreateForm = ({ curStep }: { curStep: number }) => { |
apps/web/src/pages/upload.tsx
Outdated
|
|
||
| export default function Upload() { | ||
| const router = useRouter(); | ||
| const [pdf, setPdf] = useState<string | ArrayBuffer | null>(null); |
There was a problem hiding this comment.
You should be able to pull from main (git pull origin main) and use the useBlob hook's localBlobData state and uploadLocalBlob and clearLocalBlob functions to do operations regarding storing PDF data in state.
apps/web/src/pages/upload.tsx
Outdated
| </Text> | ||
| </Flex> | ||
| <input | ||
| type="file" |
There was a problem hiding this comment.
You should also be able to use inputFileRef from useBlob here for upload to cloud storage at the end (Review step probably)
Changes to blob: - includes size as a string for form display on upload page - takes a file rather than a change event because dropbox processes change events and gives a list of accepted files
kaiyangzheng
approved these changes
Nov 30, 2024
kaiyangzheng
deleted the
204-feature-create-form-template-upload-pdf-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created an upload page for the first step in form template process. Allows users to browse or drag pdf.
Motivation and Context
Implement redesigns for form template creation flow.
Closes [#204 ]
How has this been tested?
Tried dragging and browsing for files. Upload size and title were correctly saved/displayed. Styles were inspected and spacing matches Figma.
Screenshots (if appropriate):
Not shown in pictures but on the next page, the upload step will display as a blue check mark in the sidebar.
Types of changes
Since this redirects users creating a form template to the start of the new flow, and the other pages are not finished yet, we will not be able to create new templates using this flow until the others are implemented.
The previous modal was not deleted, there are just no links to it right now.
Checklist: