Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

174 feature profile hover for form list #197

Merged
merged 13 commits into from
Nov 24, 2024

Conversation

kaiyangzheng
Copy link
Collaborator

@kaiyangzheng kaiyangzheng commented Nov 15, 2024

Description

Added HoverableAvatar which is used on FormRows to see more details about the avatars of assignees. Hover shows their name and whether they have signed the form.

Motivation and Context

Adds a new design component to the form lists.

Closes [#197]

How has this been tested?

Tested combinations of moving on and off hover in different directions and different speeds, as early on there were issues with layered hovering (FormRow has hover as well).

Screenshots (if appropriate):

Screenshot 2024-11-23 at 12 03 28 PM Screenshot 2024-11-23 at 12 02 58 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • X ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kaiyangzheng kaiyangzheng linked an issue Nov 15, 2024 that may be closed by this pull request
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mfa-form-automator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2024 8:50pm

Gayatri-K26
Gayatri-K26 previously approved these changes Nov 24, 2024
@kaiyangzheng kaiyangzheng merged commit 273829a into main Nov 24, 2024
7 checks passed
@kaiyangzheng kaiyangzheng deleted the 174-feature-profile-hover-for-form-list branch November 24, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Profile hover for form list
3 participants