Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage works #108

Merged
merged 1 commit into from
Apr 11, 2024
Merged

storage works #108

merged 1 commit into from
Apr 11, 2024

Conversation

kaiyangzheng
Copy link
Collaborator

Description/Problem

Closes story

Remove mock storage implementation

Solution

Changed storage to real MFA storage now that the keys work

Dependencies

[ ] This PR adds new dependencies

Testing

Please describe how you tested this PR (manually and/or automatically)
Provide instructions so we can reproduce, and include screenshots of UI changes.

  • Manual Tests?
    • Add details and expected results here
  • Unit/Integration/E2E Tests?
    • Add details and expected results here

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mfa-form-automator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 5:03pm

Copy link
Contributor

@ahweigl ahweigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

Copy link
Contributor

@justagoodfriend justagoodfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, form uploading/showing up looks good

@kaiyangzheng kaiyangzheng merged commit 7785518 into main Apr 11, 2024
7 checks passed
@kaiyangzheng kaiyangzheng deleted the fix-mfa-keys branch April 11, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants