Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new output format flow #11

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Implement new output format flow #11

merged 2 commits into from
Jan 28, 2024

Conversation

rael346
Copy link
Contributor

@rael346 rael346 commented Jan 27, 2024

This PR essentially addresses #4 by

  • Adding new extensions to the save files to denote stages of the major (see the enum SaveStage)
    • initial will be always be the newest scraped majors
    • staging will be the version that the commit version is based of off when using Tooling to check
    • commit will be the version of majors that are used by Graduate in prod
  • Have a specific flow when scraping a major (in classify.ts)
    • When a new major's html is fetched from the catalog, it will be checked against the staging.html of that major
    • If that major doesn't exist, then that major will continue to be tokenized and parsed in the initial stage
    • If that major does exist and the staging version is different from the fetch one, then the major will continue as initial stage
    • If that major does exist and the staging version is the same, then the major will continue with the staging version

A few items that arose during this ticket that should be addressed in a latter one:

@rael346 rael346 added the Feature New feature or request label Jan 27, 2024
@rael346 rael346 self-assigned this Jan 27, 2024
Copy link
Member

@AlpacaFur AlpacaFur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!!!

@rael346 rael346 merged commit 1c0acea into main Jan 28, 2024
@rael346 rael346 deleted the implement-new-flow branch January 28, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants