Move output password removal after functional text matching #67754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a user uses a common dictionary password, like
password
, Salt replaces the word from the command buffer. Currently, this causessalt-ssh
to hang when the remote is asking for password, because the wordpassword
is replaced and the text matching fails to detect that the ssh session hangs waiting for password input.In this PR, I:
Server
, we don't want to replace something like-o ServerAliveInterval=60
to-o ******AliveInterval=60
. This makes the password easy to guess from the logs.This change fixes regression caused by #62641
Note: Tests already exist, and were added as part of #62641.
What issues does this PR fix or reference?
Fixes #65787 #65406
Previous Behavior
Salt-ssh would fail to establish connection when connecting to host that uses the word
password
as password.New Behavior
Salt-ssh establishes connection to hosts even when those hosts use
password
as password.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes