[3007.x] Remove support for Python 3.8 from pre-commit and requirements #67732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
previously approved these changes
Feb 12, 2025
dmurphy18
added
test:core
|
I left a comment on the 3006.x version of this PR... but the same question applies here, of course. |
dmurphy18
changed the title
twangboy
previously approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes support for Python 3.8 from pre-commit and support in generated requirements for those versions of Python
Leaving support for Python 3.9 as this is required at the moment in order to build, that is, build tools/scripts/actions are currently making use of system python, for example: Rocky Linux 9 is using Python 3.9.
What issues does this PR fix or reference?
Fixes #67730
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.