[BUGFIX] Fix missing arguments for random methods

sabbelasichon · Nov 20, 2020 · 3d2e3c3 · 3d2e3c3
1 parent f0021ee
commit 3d2e3c3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/src/Rector/v8/v0/RandomMethodsToRandomClassRector.php b/src/Rector/v8/v0/RandomMethodsToRandomClassRector.php
@@ -47,10 +47,10 @@ public function refactor(Node $node): ?Node
         );
 
         if ($this->isName($node->name, self::GENERATE_RANDOM_BYTES)) {
-            return $this->createMethodCall($randomClass, self::GENERATE_RANDOM_BYTES);
+            return $this->createMethodCall($randomClass, self::GENERATE_RANDOM_BYTES, $node->args);
         }
 
-        return $this->createMethodCall($randomClass, 'generateRandomHexString');
+        return $this->createMethodCall($randomClass, 'generateRandomHexString', $node->args);
     }
 
     /**

diff --git a/stubs/Core/Utility/GeneralUtility.php b/stubs/Core/Utility/GeneralUtility.php
@@ -122,12 +122,12 @@ public static function getFileAbsFileName($filename): void
 
     }
 
-    public static function generateRandomBytes(): string
+    public static function generateRandomBytes($bytesToReturn): string
     {
         return 'bytes';
     }
 
-    public static function getRandomHexString(): string
+    public static function getRandomHexString($count): string
     {
         return 'hex';
     }

diff --git a/tests/Rector/v8/v0/RandomMethodsToRandomClass/Fixture/random_methods_to_random_class.php.inc b/tests/Rector/v8/v0/RandomMethodsToRandomClass/Fixture/random_methods_to_random_class.php.inc
@@ -2,14 +2,16 @@
 
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
-$randomBytes = GeneralUtility::generateRandomBytes();
-$randomHex = GeneralUtility::getRandomHexString();
+$randomBytes = GeneralUtility::generateRandomBytes(8);
+$count = 7;
+$randomHex = GeneralUtility::getRandomHexString($count);
 
 ?>
 -----
 <?php
 
 use TYPO3\CMS\Core\Crypto\Random;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
-$randomBytes = GeneralUtility::makeInstance(Random::class)->generateRandomBytes();
-$randomHex = GeneralUtility::makeInstance(Random::class)->generateRandomHexString();
+$randomBytes = GeneralUtility::makeInstance(Random::class)->generateRandomBytes(8);
+$count = 7;
+$randomHex = GeneralUtility::makeInstance(Random::class)->generateRandomHexString($count);