Bug fix

sa-si-dev · Nov 20, 2022 · a380439 · a380439
1 parent b61b63f
commit a380439
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "virtual-select-plugin",
-  "version": "1.0.34",
+  "version": "1.0.35",
   "description": "A javascript plugin for dropdown with virtual scroll",
   "scripts": {
     "start": "webpack --mode development --watch",

diff --git a/src/virtual-select.js b/src/virtual-select.js
@@ -1213,7 +1213,9 @@ export class VirtualSelect {
       }
     };
 
-    options.forEach(prepareOption);
+    if (Array.isArray(options)) {
+      options.forEach(prepareOption);
+    }
 
     const optionsLength = preparedOptions.length;
     const { $ele } = this;
@@ -2506,7 +2508,12 @@ export class VirtualSelect {
       return;
     }
 
-    const groupIndex = DomUtils.getData($option, 'groupIndex', 'number');
+    let groupIndex = DomUtils.getData($option, 'groupIndex');
+
+    if (groupIndex !== undefined) {
+      groupIndex = parseInt(groupIndex);
+    }
+
     const $group = this.$options.querySelector(`.vscomp-option[data-index="${groupIndex}"]`);
     const isAllSelected = typeof isSelected === 'boolean' ? isSelected : this.isAllGroupOptionsSelected(groupIndex);