Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change view access role with read access #614

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

MarcoIeni
Copy link
Member

@MarcoIeni MarcoIeni commented Oct 10, 2024

Discussed with JD.

Read only gives more visibility.

@MarcoIeni MarcoIeni force-pushed the give-infra-team-read-access-instead-of-view branch from 48c8ba2 to 156f67d Compare October 10, 2024 12:38
@MarcoIeni MarcoIeni changed the title give infra team read access instead of view change view access role with read access Oct 10, 2024
@MarcoIeni MarcoIeni force-pushed the give-infra-team-read-access-instead-of-view branch from 156f67d to c41e539 Compare October 10, 2024 12:40
@MarcoIeni MarcoIeni marked this pull request as ready for review October 10, 2024 12:41
@MarcoIeni
Copy link
Member Author

MarcoIeni commented Oct 10, 2024

Plan

14:58:43.130 STDOUT terraform:   + create
14:58:43.130 STDOUT terraform: Terraform will perform the following actions:
14:58:43.130 STDOUT terraform:   # module.sso_account_assignment["dev-desktops-prod"].aws_ssoadmin_account_assignment.account_group_permission["infra-admins[ViewOnlyAccess]"] will be created
14:58:43.130 STDOUT terraform:   + resource "aws_ssoadmin_account_assignment" "account_group_permission" {
14:58:43.130 STDOUT terraform:       + id                 = (known after apply)
14:58:43.130 STDOUT terraform:       + instance_arn       = "arn:aws:sso:::instance/ssoins-72236e90633f0325"
14:58:43.130 STDOUT terraform:       + permission_set_arn = "arn:aws:sso:::permissionSet/ssoins-72236e90633f0325/ps-15e41bbf18a7dd68"
14:58:43.130 STDOUT terraform:       + principal_id       = "f4880468-0021-707f-2472-306e771fd1ea"
14:58:43.130 STDOUT terraform:       + principal_type     = "GROUP"
14:58:43.130 STDOUT terraform:       + target_id          = "826384318366"
14:58:43.130 STDOUT terraform:       + target_type        = "AWS_ACCOUNT"
14:58:43.130 STDOUT terraform:     }
14:58:43.130 STDOUT terraform:   # module.sso_account_assignment["dev-desktops-prod"].aws_ssoadmin_account_assignment.account_group_permission["infra[ViewOnlyAccess]"] will be created
14:58:43.130 STDOUT terraform:   + resource "aws_ssoadmin_account_assignment" "account_group_permission" {
14:58:43.130 STDOUT terraform:       + id                 = (known after apply)
14:58:43.130 STDOUT terraform:       + instance_arn       = "arn:aws:sso:::instance/ssoins-72236e90633f0325"
14:58:43.130 STDOUT terraform:       + permission_set_arn = "arn:aws:sso:::permissionSet/ssoins-72236e90633f0325/ps-15e41bbf18a7dd68"
14:58:43.130 STDOUT terraform:       + principal_id       = "e40884a8-9021-7098-ba89-1f2ab32bab88"
14:58:43.130 STDOUT terraform:       + principal_type     = "GROUP"
14:58:43.130 STDOUT terraform:       + target_id          = "826384318366"
14:58:43.130 STDOUT terraform:       + target_type        = "AWS_ACCOUNT"
14:58:43.131 STDOUT terraform:     }
14:58:43.131 STDOUT terraform:   # module.sso_account_assignment["docs-rs-staging"].aws_ssoadmin_account_assignment.account_group_permission["infra-admins[ViewOnlyAccess]"] will be created
14:58:43.131 STDOUT terraform:   + resource "aws_ssoadmin_account_assignment" "account_group_permission" {
14:58:43.131 STDOUT terraform:       + id                 = (known after apply)
14:58:43.131 STDOUT terraform:       + instance_arn       = "arn:aws:sso:::instance/ssoins-72236e90633f0325"
14:58:43.131 STDOUT terraform:       + permission_set_arn = "arn:aws:sso:::permissionSet/ssoins-72236e90633f0325/ps-15e41bbf18a7dd68"
14:58:43.131 STDOUT terraform:       + principal_id       = "f4880468-0021-707f-2472-306e771fd1ea"
14:58:43.131 STDOUT terraform:       + principal_type     = "GROUP"
14:58:43.131 STDOUT terraform:       + target_id          = "519825364412"
14:58:43.131 STDOUT terraform:       + target_type        = "AWS_ACCOUNT"
14:58:43.131 STDOUT terraform:     }
14:58:43.131 STDOUT terraform:   # module.sso_account_assignment["docs-rs-staging"].aws_ssoadmin_account_assignment.account_group_permission["infra[ViewOnlyAccess]"] will be created
14:58:43.131 STDOUT terraform:   + resource "aws_ssoadmin_account_assignment" "account_group_permission" {
14:58:43.131 STDOUT terraform:       + id                 = (known after apply)
14:58:43.131 STDOUT terraform:       + instance_arn       = "arn:aws:sso:::instance/ssoins-72236e90633f0325"
14:58:43.131 STDOUT terraform:       + permission_set_arn = "arn:aws:sso:::permissionSet/ssoins-72236e90633f0325/ps-15e41bbf18a7dd68"
14:58:43.131 STDOUT terraform:       + principal_id       = "e40884a8-9021-7098-ba89-1f2ab32bab88"
14:58:43.131 STDOUT terraform:       + principal_type     = "GROUP"
14:58:43.131 STDOUT terraform:       + target_id          = "519825364412"
14:58:43.131 STDOUT terraform:       + target_type        = "AWS_ACCOUNT"
14:58:43.131 STDOUT terraform:     }
14:58:43.131 STDOUT terraform:   # module.sso_account_assignment["rust-root"].aws_ssoadmin_account_assignment.account_group_permission["infra[ViewOnlyAccess]"] will be created
14:58:43.131 STDOUT terraform:   + resource "aws_ssoadmin_account_assignment" "account_group_permission" {
14:58:43.131 STDOUT terraform:       + id                 = (known after apply)
14:58:43.131 STDOUT terraform:       + instance_arn       = "arn:aws:sso:::instance/ssoins-72236e90633f0325"
14:58:43.131 STDOUT terraform:       + permission_set_arn = "arn:aws:sso:::permissionSet/ssoins-72236e90633f0325/ps-15e41bbf18a7dd68"
14:58:43.132 STDOUT terraform:       + principal_id       = "e40884a8-9021-7098-ba89-1f2ab32bab88"
14:58:43.132 STDOUT terraform:       + principal_type     = "GROUP"
14:58:43.132 STDOUT terraform:       + target_id          = "762490340130"
14:58:43.132 STDOUT terraform:       + target_type        = "AWS_ACCOUNT"
14:58:43.132 STDOUT terraform:     }

@MarcoIeni MarcoIeni force-pushed the give-infra-team-read-access-instead-of-view branch from 5904d9b to adfed96 Compare October 10, 2024 13:02
@MarcoIeni MarcoIeni merged commit 1161f2e into master Oct 10, 2024
3 checks passed
@MarcoIeni MarcoIeni deleted the give-infra-team-read-access-instead-of-view branch October 10, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant