Implement unstable new_range feature
#136167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
rustbot
added
S-waiting-on-review
Nadrieril
reviewed
Jan 29, 2025
| if NEW_RANGE { | ||
| hir::LangItem::RangeInclusiveCopy | ||
| } else { | ||
| unreachable!() // Handled by lower_expr_range_closed |
There was a problem hiding this comment.
nit: could you call lower_expr_range_closed here instead of in the match above?
There was a problem hiding this comment.
Yeah that's much cleaner, good point.
This comment has been minimized.
This comment has been minimized.
for RFC 3550, tracking issue rust-lang#123741
21 tasks
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 4, 2025
Rollup of 5 pull requests Successful merges: - rust-lang#134777 (Enable more tests on Windows) - rust-lang#135621 (Move some std tests to integration tests) - rust-lang#135844 ( Add new tool for dumping feature status based on tidy ) - rust-lang#136167 (Implement unstable `new_range` feature) - rust-lang#136334 (Extract `core::ffi` primitives to a separate (internal) module) Failed merges: - rust-lang#136201 (Removed dependency on the field-offset crate, alternate approach) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 4, 2025
Rollup merge of rust-lang#136167 - pitaj:new_range, r=Nadrieril Implement unstable `new_range` feature Switches `a..b`, `a..`, and `a..=b` to resolve to the new range types. For rust-lang/rfcs#3550 Tracking issue rust-lang#123741 also adds the re-export that was missed in the original implementation of `new_range_api`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches
a..b,a.., anda..=bto resolve to the new range types.For rust-lang/rfcs#3550
Tracking issue #123741
also adds the re-export that was missed in the original implementation of
new_range_api