Merge pull request #55 from runwaylab/type-update

Type updates and branch-deploy type checks

acceptance/logs/expected.log

@@ -3,7 +3,7 @@ INFO: 📖 loading runway configuration
 DEBUG: attempting to load config from acceptance/config/config.yml
 INFO: ✅ loaded configuration successfully
 INFO: 🚚 2 projects loaded
-INFO: 🛫 starting runway - version: v0.5.2
+INFO: 🛫 starting runway - version: v0.5.3
 INFO: 📦 starting project project-1
 INFO: 🕐 scheduling event with interval 3s for project-1
 INFO: 📦 starting project project-2

shard.yml

@@ -1,5 +1,5 @@
 name: runway
-version: 0.5.2
+version: 0.5.3
 
 authors:
   - GrantBirki

src/runway/events/github_deployment.cr

@@ -210,6 +210,13 @@ class GitHubDeployment < BaseEvent
     begin
       deployment_payload = deployment.payload.to_json
       @log.debug { "deployment_payload for #{@repo}: #{deployment_payload}" }
+
+      # if the deployment type is not of the branch-deploy type (or if it's not set), we'll skip hydration
+      if deployment_payload["type"].try(&.to_s) != "branch-deploy"
+        @log.debug { "deployment type is not branch-deploy for #{@repo} - skipping branch_deploy payload hydration" }
+        return nil
+      end
+
       BranchDeployPayload.from_json(deployment_payload)
     rescue e : Exception
       log_message = "failed to parse branch_deploy payload for #{@repo}: #{e.message}"
@@ -233,7 +240,7 @@ class GitHubDeployment < BaseEvent
   # It then sorts the deployments as well
   # @param deployments [String] the deployments raw JSON response
   # @return [Array] the parsed, filtered, and sorted deployments
-  protected def parse_and_filter_deployments(deployments : Octokit::Connection::Paginator(Octokit::Models::Deployment)) : Array
+  protected def parse_and_filter_deployments(deployments : Octokit::Connection::Paginator(Octokit::Models::Deployment)) : Array(Octokit::Models::Deployment)
     deployments = filter_deployments(deployments.records)
     sort_deployments(deployments)
   end

src/version.cr

@@ -1,3 +1,3 @@
 module Runway
-  VERSION = "v0.5.2"
+  VERSION = "v0.5.3"
 end