Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor make output to be cleaner #657

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Conversation

matsl
Copy link
Collaborator

@matsl matsl commented Jan 29, 2025

What

  • Add verbosity macros for a cleaner build experience
  • Make loads silent for a cleaner build experience
  • Set byte-compile-warnings to 'all
  • Remove warnings for docstring uses curved single quotes

It seems you need to control or shift click for getting to the build step directly on these links below.

Example of new build compile step - master

Example of old build compile step - master

Why

A cluttered build output makes it harder to see issues. This PR is
inspired by the Emacs make file for the representation of each build
step using macros for controlling output and verbosity.

Load messages have been silenced to make it even further clean.

In addition to that the "new" feature of allowing new warnings, still
not in the default set, to be active, has been applied and the
warnings have been fixed.

Note

There is an issue with string-replace for 27.2 that is not part of
this PR. It does not affect the unit tests and has been going under
our radar. It is more visible when the output from the build is
stripped from noise.

@matsl matsl requested a review from rswgnu January 29, 2025 22:09
@matsl matsl merged commit 661b497 into master Jan 30, 2025
4 checks passed
@matsl matsl deleted the refactor-make-output-to-be-cleaner branch January 30, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants