Matsl rsw hui link possible types #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests are failing; Mats, see if you can fix them.
Make hyrolo cache variables buffer-local to allow multiple commands
to have their own hyrolo display buffers.
Fix hyrolo-logic.el to handle multiple file formats (not yet tested).
test/hyrolo-tests.el (hyrolo-demo-move-to-beginning-and-end-of-file):
Move to {,} and {.} tests to sep test.
kotl-mode - Fix check of 'kotl-previous-mode' to not set local vars if prior mode was the same, i.e. kotl-mode.
Fix HyRolo file wildcard handling in hpath:expand-list.
(hyrolo-to-entry-end): Remove unused arg '_curr-entry-level-len'. (hyrolo-grep-file): Remove unneeded passing of 'curr-entry-level-len' arg to (hyrolo-outline-previous-visible-heading, hyrolo-next-visible-heading): Fix doc strings to mention stops at match buffer headers.
hibtypes.el (Info-node): Tighten match to limit valid chars after closing paren.
(hyrolo-stuck-msg): Add to jump to the position where a HyRolo match
became stuck, if ever happens, when point is on the error.
hyrolo.el (hyrolo-grep-file): Update 'Stuck looping in buffer' msg so can be
used in new 'hyrolo-stuck-msg' ibtype.
man/hyperbole.texi (Implicit Button Types): Add doc for 'hib-python-traceback'
and 'hyrolo-stuck-msg'.
hyperbole.el: The 'describe-package' function fails under Emacs 28 when multiple
maintainers are listed under the 'Maintainer' header but later Emacs versions
support a 'Maintainers' header, so include both. Change to using 'Authors'
Will also install the markdown-mode package as necessary when a Markdown file is specified in 'hyrolo-file-list'. This fixes failures with Markdown files improperly put into fundamental-mode which means their headings are not recognized properly. hload-path.el (auto-mode-alist): Setup to invoke 'outline-mode' on ".otl" suffixed files. man/hyperbole.texi (HyRolo Concepts): hyrolo.el (hyrolo-file-list): Update doc to specify allowable file suffixes and types.
Fix 'hpath--expand-auto-variable-alist' and 'hpath--resolve-auto-variable-alist' tests.
In same keymap, fix , and . movement keys. For all supported HyRolo major modes, include file headers in both hyrolo-hdr-regexp and outline-regexp.
|
Your pull request is to merge into master rather than the rsw branch. Please fix it and then I will look at this.
Thanks,
Bob
…On Mon, Dec 25, 2023 at 9:58 PM Mats Lidell ***@***.***> wrote:
@matsl <https://github.com/matsl> requested your review on: #421
<#421> Matsl rsw hui link
possible types.
—
Reply to this email directly, view it on GitHub
<#421 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5WPD2SVLVT2KIGQXMEP4TYLHZHDAVCNFSM6AAAAABBCUKPL6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGMZTMNBUGQZTQOI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Though you may want to wait for my next push first as it has a variable name change affecting a bunch of files and fixes a number of other issues, so you may want to base of that. -- Bob
…On Tue, Dec 26, 2023 at 12:58 AM Robert Weiner ***@***.***> wrote:
Your pull request is to merge into master rather than the rsw branch.
Please fix it and then I will look at this.
Thanks,
Bob
On Mon, Dec 25, 2023 at 9:58 PM Mats Lidell ***@***.***>
wrote:
> @matsl <https://github.com/matsl> requested your review on: #421
> <#421> Matsl rsw hui link
> possible types.
>
> —
> Reply to this email directly, view it on GitHub
> <#421 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE5WPD2SVLVT2KIGQXMEP4TYLHZHDAVCNFSM6AAAAABBCUKPL6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGMZTMNBUGQZTQOI>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
|
Disable reveal-mode until can get it to work properly with outline-minor-mode. Fix hyrolo-tests.el tests that prompt to re-read-in files.
Hmm... Interesting. I was not aware that you can have PRs that request to merge into a branch that is not the master branch, Will have to look into how to do that. When we based work on other branches at work we always did it like this. When the branch you based your work on was merged to master we rebased the PR, which was trivial. From the list of commits in this PR is should be clear that my commits are committed from the, at the time, latest commit in the rsw-branch so a merge with rsw should be trivial. |
Note discrepancies from expected behavior are added as comments.
matsl
force-pushed
the
matsl-rsw-hui-link-possible-types
branch
from
b857a47 to
98edfae
Compare
|
See #422 for PR merging with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Matsl rsw hui link possible types - based on rsw branch
Why
Basing dev work on rsw branch before potential relase. See #414 for original PR based on master.