-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matsl rsw hpath expand #420
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests are failing; Mats, see if you can fix them.
Make hyrolo cache variables buffer-local to allow multiple commands to have their own hyrolo display buffers. Fix hyrolo-logic.el to handle multiple file formats (not yet tested). test/hyrolo-tests.el (hyrolo-demo-move-to-beginning-and-end-of-file): Move to {,} and {.} tests to sep test.
kotl-mode - Fix check of 'kotl-previous-mode' to not set local vars if prior mode was the same, i.e. kotl-mode.
Fix HyRolo file wildcard handling in hpath:expand-list.
(hyrolo-to-entry-end): Remove unused arg '_curr-entry-level-len'. (hyrolo-grep-file): Remove unneeded passing of 'curr-entry-level-len' arg to (hyrolo-outline-previous-visible-heading, hyrolo-next-visible-heading): Fix doc strings to mention stops at match buffer headers.
hibtypes.el (Info-node): Tighten match to limit valid chars after closing paren. (hyrolo-stuck-msg): Add to jump to the position where a HyRolo match became stuck, if ever happens, when point is on the error. hyrolo.el (hyrolo-grep-file): Update 'Stuck looping in buffer' msg so can be used in new 'hyrolo-stuck-msg' ibtype. man/hyperbole.texi (Implicit Button Types): Add doc for 'hib-python-traceback' and 'hyrolo-stuck-msg'. hyperbole.el: The 'describe-package' function fails under Emacs 28 when multiple maintainers are listed under the 'Maintainer' header but later Emacs versions support a 'Maintainers' header, so include both. Change to using 'Authors'
I merged this branch manually into the rsw branch since that is easier for me to fix the merge conflicts locally. So we can close this pull request without using it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Matsl rsw hpath expand
Why
Test of
hpath-exand et al
based on thersw
branch.Note
Since this is based on rsw branch it might be easier to review using the commit Also set "Do NOT MERGE" labels so it is clear this need to go in as part of or after the rsw branch.