Handle I'm Feeling Lucky with ">" and "lucky" keyword shortcuts #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More about this pull request at: #64 |
|
I think it would be better to add a key to service providers (i.e.: LuckyURLTemplate) instead of adding a new kind of search provider. |
|
I would too. But wouldn't it be messy to have too many keys and values for a single item? And more code to handle differentiating between search and feeling lucky request type. |
|
It's better to have several properties for a single provider than having to duplicate a provider. You shouldn't have feeling lucky url on a provider that haven't a search url right? In the future I also see a third url template for suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could have been just adding ">" to the plist. But didn't like that it wasn't performing the same as "?" (had to press a space).