Require one transaction ID for history list + info #2214
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Require one transaction ID for
dnf history
command actionslist
andinfo
. This is a bugfix that resolves #2213.Currently,
dnf history
command actionslist
andinfo
are missing from the set of actions which should require one transaction ID.Implementation details
Set
self._require_one_transaction_id = True
fordnf history
command actionslist
andinfo
.Testing
Using a Fedora 41 instance with
containerd
not installed, I randnf history list containerd
anddnf history info containerd
with and without the changes from this pull request.I verified that without these changes, the commands return a zero exit status and do not write a message to
stderr
.Click here to expand for full output of commands without changes from this pull request
I also built from source with these pull request's changes included (by following these instructions) and then verified using the built
dnf
that the commands return a non-zero exit status and write an error message tostderr
.Click here to expand for full output of commands with changes from this pull request