Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address correct "const" usage in simple message library. #1

Open
shaun-edwards opened this issue Jun 4, 2013 · 1 comment
Open

Address correct "const" usage in simple message library. #1

shaun-edwards opened this issue Jun 4, 2013 · 1 comment
Assignees
@shaun-edwards
Labels
enhancement
Milestone
Jade Release

Comments

@shaun-edwards
Copy link
Member

connection.init(char ) => .init(const char)

I don't see why the IP address in the different client init functions shouldn't be const. I'm having to fix it in my code and there's a hack in joint_trajectory_interface.cpp:60 which also painfully addresses it.

2 participants
JeremyZoss commented 7 days ago

Agreed. There are many other areas in the core libraries that could probably be improved for const-correctness. But these things kind of have a way of cascading to make small changes trigger much larger changes. So, I agree in theory, but we may need to be selective about what code is updated to prevent potentially breaking higher-level code that builds on these libraries.
@ghost ghost assigned shaun-edwards Jun 4, 2013
@gavanderhoorn
Copy link
Member

See also #15 (sorry about that, didn't see this one).

Jmeyer1292 pushed a commit to Jmeyer1292/industrial_core that referenced this issue Feb 14, 2017
@gavanderhoorn
Avoid hardcoded python path. Fix ros-industrial#1.
24cac49
Jmeyer1292 pushed a commit to Jmeyer1292/industrial_core that referenced this issue Feb 14, 2017
@shaun-edwards
Merge pull request ros-industrial#2 from gavanderhoorn/issue1_hardcod…
b67f01a 
…ed_python_path

Fix issue ros-industrial#1: hard coded Python path in multiple scripts
Jmeyer1292 pushed a commit to Jmeyer1292/industrial_core that referenced this issue Feb 14, 2017
@jrgnicho
Merge pull request ros-industrial#1 from ros-industrial/master
83e972a 
updating master branch on this fork
fmessmer added a commit to fmessmer/industrial_core that referenced this issue Jan 20, 2021
@fmessmer
Bump CMake version to avoid CMP0048 warning (ros-industrial#1)
e7af684
simonschmeisser referenced this issue in isys-vision/industrial_core Apr 7, 2021
@fmessmer @simonschmeisser
Bump CMake version to avoid CMP0048 warning (antonxy#1)
124041c
fmessmer added a commit to fmessmer/industrial_core that referenced this issue May 5, 2021
@fmessmer
Merge pull request ros-industrial#1 from fmessmer/fix_catkin_lint
d9a68bf 
fix catkin_lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaun-edwards shaun-edwards

Labels
enhancement
Milestone
Jade Release
Development

No branches or pull requests
2 participants
@shaun-edwards @gavanderhoorn