Fix Dockerfile #952
Merged
Fix Dockerfile #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santib
commented
Jan 14, 2025
| @@ -23,7 +23,7 @@ ENV NODE_ENV=production | |||
| FROM base AS builder | |||
|
|
|||
| RUN apt-get update -qq && \ | |||
| apt-get install -y build-essential libssl-dev libpq-dev git libsasl2-dev curl && \ | |||
| apt-get install -y build-essential libssl-dev libpq-dev git libsasl2-dev libyaml-dev curl && \ | |||
There was a problem hiding this comment.
not sure if it's needed in both places.
Also, what about Dockerfile.dev ?
There was a problem hiding this comment.
This Dockerfile uses a Multi-stage build strategy.
The first part of this file creates a "builder" image that is only used for setting up the app dependencies, gems, assets precompilation, etc. And the final part is actually the "runtime" image.
If the library is needed for both build and runtime, we need to add it in both places. I think this change is correct 👍
Regarding the Dockerfile.dev, it does not implement multi-stage, but if it is a runtime dependency I think we should add it there as well
There was a problem hiding this comment.
santib
force-pushed
the
fix-dockerfile
branch
from
2c59bf6 to
b022838
Compare
JulianPasquale
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example error: https://github.com/rootstrap/rails_api_base/actions/runs/12769411348/job/35591931172