Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capybara #536

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Add capybara #536

merged 1 commit into from
Dec 7, 2023

Conversation

sebastiancaraballo
Copy link
Contributor

Board:

Description:

  • Add capybara
  • Test admin sign-in

@sebastiancaraballo sebastiancaraballo requested a review from a team December 4, 2023 14:29
@sebastiancaraballo
Copy link
Contributor Author

The tests are failing because there's a problem with a dependency. I resolved this issue locally running yarn install. How can I solve this here? Help appreciated cc @santib

@santib
Copy link
Member

santib commented Dec 4, 2023 •
edited
Loading

The tests are failing because there's a problem with a dependency. I resolved this issue locally running yarn install. How can I solve this here? Help appreciated cc @santib

I think you need to add that step yarn install to the CI setup 👍

Example: https://eric.sau.pe/rails-system-tests-with-github-actions

@sebastiancaraballo sebastiancaraballo force-pushed the feature/capybara branch 2 times, most recently from 65e3678 to 38edbb9 Compare December 4, 2023 16:46
enzofab91
enzofab91 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@enzofab91 enzofab91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

spec/features/admin/sign_in_spec.rb Outdated Show resolved Hide resolved
santib
santib approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@santib santib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@santib santib requested a review from a team December 4, 2023 21:26
blacksam07
blacksam07 reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@blacksam07 blacksam07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

spec/features/admin/sign_in_spec.rb Outdated Show resolved Hide resolved
@santib
Copy link
Member

santib commented Dec 6, 2023

@sebastiancaraballo maybe we should create a follow up ticket so we add support to run it locally in non-headless mode using chrome?

@sebastiancaraballo sebastiancaraballo force-pushed the feature/capybara branch 2 times, most recently from 001f86c to 90f291d Compare December 7, 2023 12:38
@sebastiancaraballo sebastiancaraballo merged commit 3cc011c into main Dec 7, 2023
@sebastiancaraballo sebastiancaraballo deleted the feature/capybara branch December 7, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santib santib santib approved these changes

@blacksam07 blacksam07 blacksam07 left review comments

@DJA89 DJA89 DJA89 approved these changes

@enzofab91 enzofab91 enzofab91 approved these changes

@JulianPasquale JulianPasquale JulianPasquale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sebastiancaraballo @santib @DJA89 @enzofab91 @JulianPasquale @blacksam07