feat: priority order for plugin version

roflmuffin · Oct 10, 2024 · 0b2d9a1 · 0b2d9a1
1 parent 748c9cd
commit 0b2d9a1
Showing 1 changed file with 21 additions and 1 deletion.
diff --git a/managed/CounterStrikeSharp.API/Core/Plugin/PluginContext.cs b/managed/CounterStrikeSharp.API/Core/Plugin/PluginContext.cs
@@ -204,6 +204,26 @@ public void Load(bool hotReload = false)
 
                 if (Plugin == null) throw new Exception("Unable to create plugin instance");
 
+                /* Version Priority order:
+                 *  ModuleVersion override
+                 *  Assembly.GetName().Version
+                 *  "<unknown>"
+                 */
+                if (Plugin is BasePlugin basePlugin)
+                {
+                    // if no override we look for assembly version
+                    if (basePlugin._version == "<unknown>")
+                    {
+                        Version? assemblyVersion = defaultAssembly.GetName().Version;
+
+                        // if its set, we use that, otherwise it remains "<unknown>"
+                        if (assemblyVersion != null)
+                        {
+                            basePlugin._version = assemblyVersion.ToString();
+                        }
+                    }
+                }
+
                 State = PluginState.Loading;
 
                 Plugin.ModulePath = _path;
@@ -241,4 +261,4 @@ public void Unload(bool hotReload = false)
             _logger.LogInformation("Finished unloading plugin {Name}", cachedName);
         }
     }
-}
+}