Maintains compatibility with CLI return, broken in PR #266 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrosemberg
commented
Aug 18, 2024
Comment on lines
-572
to
+584
| dict_part = str(error).split(": ", 2)[2] | ||
| error_str = str(error) | ||
| start_idx = error_str.index("{") | ||
| end_idx = error_str.rindex("}") + 1 | ||
| dict_part = error_str[start_idx:end_idx] |
There was a problem hiding this comment.
This fixes the bug reported here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In PR #266 the raised errors changed how the CLI response is sent.
Said that, what this PR does?
_log_img_upload_errthat earlier is shared with_log_img_uploadproject.uploadType of change
How has this change been tested, please provide a testcase or example of how you tested the change?
project.uploadbugfix