Block gallery refactor #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansent
requested review from
capjamesg,
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
EmilyGavrilenko and
probicheaux
as code owners
grzegorz-roboflow
requested changes
Jan 24, 2025
grzegorz-roboflow
approved these changes
Jan 24, 2025
PawelPeczek-Roboflow
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renders block Gallery as actual HTML using jinja template and pulls icons / sections from ui manifests
We can style / improve further in follow up PR, but this is already better since in addition to the section and icons matching the ones in app / other material, it actually renders the content to page instead of relying on client side JS to populate, so this page can get indexed.
Type of change
docs
How has this change been tested, please provide a testcase or example of how you tested the change?
local build
Any specific deployment considerations
n/a
Docs
this is a docs update