Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netowrk: enable dnsconfd service in installer environment #6184

Open
wants to merge 1 commit into
base: rhel-10
Choose a base branch
from

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Feb 18, 2025

TODO:

  • update kickstart tests

@rvykydal
Copy link
Contributor Author

/build-image

Copy link

Images built based on commit 2dac7ac:

  • boot.iso: success

Download the images from the bottom of the job status page.

Enable dnsconfd service based on rd.net.dns-backend kernel option

Resolves: RHEL-80011
@rvykydal rvykydal force-pushed the enable-dnsconfd-service-r10 branch from 2dac7ac to 9a86c86 Compare February 18, 2025 14:28
@rvykydal rvykydal marked this pull request as ready for review February 18, 2025 15:18
@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

@jkonecny12
Copy link
Member

jkonecny12 commented Feb 18, 2025

Shouldn't this be handled by the dnsconfd directly? Seems to me that they can have their unit conditioned by this option all the time.

Is there a reason why we should be involved?

@rvykydal
Copy link
Contributor Author

rvykydal commented Feb 19, 2025

Shouldn't this be handled by the dnsconfd directly? Seems to me that they can have their unit conditioned by this option all the time.

Is there a reason why we should be involved?

Yes, I was thinking the same. I think the reason was the use case where dnsconfd is not enabled in initramfs but should be enabled in installed system. But thinking of it again it would be more futureproof if the enablement would be owned by dnsconfd, for example if there was a (new separate if needed) intiramfs service owned by dnsconfd that would do the same as the shell script in this PR: if rd.net.dns-backend kernel option has dnsconfd value, enable the dnsconfd service on the root system. What do you think @TomasKorbar ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants