-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network: update NM autoconnections configuration for centos #6142
base: main
Are you sure you want to change the base?
network: update NM autoconnections configuration for centos #6142
Conversation
/kickstart-test --testtype smoke |
@@ -1,7 +1,8 @@ | |||
[Unit] | |||
ConditionKernelCommandLine=|ip | |||
ConditionKernelCommandLine=|inst.ks | |||
ConditionOSRelease=ID=rhel | |||
ConditionOSRelease=|ID=rhel | |||
ConditionOSRelease=|ID=centos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the other RHEL-like distributions? AlmaLinux and so on. Is there a possibility to have a more general way to fix it everywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, maybe we could use ID_LIKE exists and ID_LIKE contains "rhel".
I'll see if/how we can express it by systemd Condition.
@jstodola In the end I added a separate condition for rhel-like systems. I'd like to keep centos condition separately to be on the safer side here, as the condition seems a bit more fragile to me (ID_LIKE being a bit less predicable). Examples of ID_LIKE:
We are able to use only shell-style wildcards to check the value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, thanks.
/kickstart-test --testtype smoke |
|
/kickstart-test --kstest-pr 1367 network-autoconnections-httpks |
1 similar comment
/kickstart-test --kstest-pr 1367 network-autoconnections-httpks |
The test failed on rawhide when I added the commit network: update NM autoconnections configuration for rhel-like systems (it worked for me on RHEL10), same as kickstart smoke tests:
Reported: https://bugzilla.redhat.com/show_bug.cgi?id=2345544 |
Should be fixed in systemd-257.3-3.fc43 |
/kickstart-test --kstest-pr 1367 network-autoconnections-httpks |
The policy should be the same for RHEL and CentOS Stream. Resolves: RHEL-67815
The policy should be the same as for RHEL Related: RHEL-67815
5714b3b
to
a42c123
Compare
/kickstart-test --kstest-pr 1367 network-autoconnections-httpks |
The policy should be the same for RHEL and CentOS Stream.
Resolves: RHEL-67815
TODO: