Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: update NM autoconnections configuration for centos #6142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Feb 5, 2025

The policy should be the same for RHEL and CentOS Stream.

Resolves: RHEL-67815

TODO:

@github-actions github-actions bot added the f42 Fedora 42 label Feb 5, 2025
@rvykydal
Copy link
Contributor Author

rvykydal commented Feb 6, 2025

/kickstart-test --testtype smoke

@@ -1,7 +1,8 @@
[Unit]
ConditionKernelCommandLine=|ip
ConditionKernelCommandLine=|inst.ks
ConditionOSRelease=ID=rhel
ConditionOSRelease=|ID=rhel
ConditionOSRelease=|ID=centos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the other RHEL-like distributions? AlmaLinux and so on. Is there a possibility to have a more general way to fix it everywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, maybe we could use ID_LIKE exists and ID_LIKE contains "rhel".
I'll see if/how we can express it by systemd Condition.

@rvykydal
Copy link
Contributor Author

rvykydal commented Feb 12, 2025

@jstodola In the end I added a separate condition for rhel-like systems. I'd like to keep centos condition separately to be on the safer side here, as the condition seems a bit more fragile to me (ID_LIKE being a bit less predicable). Examples of ID_LIKE:

centos: "rhel fedora"
rocky: "rhel centos fedora"
almalinux: "rhel centos fedora"

We are able to use only shell-style wildcards to check the value.

Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thanks.

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

@rvykydal
Copy link
Contributor Author

rvykydal commented Feb 12, 2025

/kickstart-test --kstest-pr 1367 network-autoconnections-htttps

@rvykydal
Copy link
Contributor Author

/kickstart-test --kstest-pr 1367 network-autoconnections-httpks

1 similar comment
@rvykydal
Copy link
Contributor Author

/kickstart-test --kstest-pr 1367 network-autoconnections-httpks

@rvykydal
Copy link
Contributor Author

rvykydal commented Feb 13, 2025

/kickstart-test --kstest-pr 1367 network-autoconnections-httpks

The test failed on rawhide when I added the commit network: update NM autoconnections configuration for rhel-like systems (it worked for me on RHEL10), same as kickstart smoke tests:

[  OK  ] Reached target ssh-access.target - SSH Access Available.
[  OK  ] Listening on systemd-hostnamed.socket - Hostname Service Socket.
[  OK  ] Reached target sockets.target - Socket Units.
         Starting dbus-broker.service - D-Bus System Message Bus...
[  OK  ] Started dbus-broker.service - D-Bus System Message Bus.
[  OK  ] Reached target basic.target - Basic System.
         Starting anaconda-import-initramfs… stage of Anaconda via kickstart...
[   17.958336] systemd[1]: segfault at 0 ip 00007f5be2bea79c sp 00007ffeae1aecd8 error 4 in libc.so.6[15a79c,7f5be2a90000+170000] likely on CPU 0 (core 0, socket 0)
[   17.959302] Code: ff ff 48 89 f8 0f bc c9 f3 a4 c3 0f 1f 00 f3 0f 1e fa 89 f8 62 a1 fd 00 ef c0 25 ff 0f 00 00 3d e0 0f 00 00 0f 87 24 01 00 00 <62> f1 7d 20 74 07 c5 fb 93 c0 85 c0 74 16 0f bc c0 c3 66 90 0f bc
         Starting anaconda-nm-config.servic…nda NetworkManager configuration...

crash_rawhide.txt

Reported: https://bugzilla.redhat.com/show_bug.cgi?id=2345544

@KKoukiou KKoukiou added f43 and removed f42 Fedora 42 labels Feb 13, 2025
@rvykydal
Copy link
Contributor Author

Reported: https://bugzilla.redhat.com/show_bug.cgi?id=2345544

Should be fixed in systemd-257.3-3.fc43

@rvykydal
Copy link
Contributor Author

/kickstart-test --kstest-pr 1367 network-autoconnections-httpks

The policy should be the same for RHEL and CentOS Stream.

Resolves: RHEL-67815
The policy should be the same as for RHEL

Related: RHEL-67815
@rvykydal rvykydal force-pushed the update-autoconnection-config-for-centos branch from 5714b3b to a42c123 Compare February 17, 2025 13:16
@rvykydal
Copy link
Contributor Author

/kickstart-test --kstest-pr 1367 network-autoconnections-httpks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants