Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LVM auto-activation during installation #6140

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vojtechtrefny
Copy link
Contributor

We don't want udev randomly activating LVs during installation, any activation should be done manually by blivet.
Unfortunately the only way to do this system-wide is to change LVM config. We change the config during the storage module initialization and change it back when shutting down Anaconda.

Related: rhbz#2309350

Blocked by: storaged-project/blivet#1340

@vojtechtrefny vojtechtrefny added the blocked Don't merge this pull request! label Feb 5, 2025
@github-actions github-actions bot added the f42 Fedora 42 label Feb 5, 2025
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need a bump in pythonblivetver in the specfile or a try catch where we would only conditionally run disable_lvm_autoactivation if it's exported from LVM module.
I prefer the latter.

@vojtechtrefny vojtechtrefny force-pushed the main_lvm-autoactivation-disable branch from 042af86 to 8cfe11d Compare February 12, 2025 15:05
@vojtechtrefny vojtechtrefny added f43 and removed f42 Fedora 42 labels Feb 12, 2025
@vojtechtrefny
Copy link
Contributor Author

I bumped the blivet version to 3.12. I plan for this and few other changes to wait for Fedora 43 so waiting for a new (not yet released) blivet version shouldn't be a big deal.

We don't want udev randomly activating LVs during installation,
any activation should be done manually by blivet.
Unfortunately the only way to do this system-wide is to change
LVM config. We change the config during the storage module
initialization and change it back when shutting down Anaconda.

Related: rhbz#2309350
@vojtechtrefny vojtechtrefny force-pushed the main_lvm-autoactivation-disable branch from 8cfe11d to 9d2026a Compare February 18, 2025 09:24
@vojtechtrefny
Copy link
Contributor Author

/kickstart-test --testtype smoke

@vojtechtrefny
Copy link
Contributor Author

/kickstart-test --testtype storage

@vojtechtrefny vojtechtrefny removed the blocked Don't merge this pull request! label Feb 18, 2025
@vojtechtrefny
Copy link
Contributor Author

Removing the blocked label, blivet 3.12.0 is now available in both rawhide and f42

KKoukiou added a commit to KKoukiou/anaconda-webui that referenced this pull request Feb 18, 2025
Tests are often failing on timeout because of LVM auto-activation [1]

[1] rhinstaller/anaconda#6140

This can be reverted once the above bug is resolved.
KKoukiou added a commit to KKoukiou/anaconda-webui that referenced this pull request Feb 18, 2025
Tests are often failing on timeout because of LVM auto-activation [1]

[1] rhinstaller/anaconda#6140

This can be reverted once the above bug is resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants