chore: test `2.18.1-canary-ws-2` #3885

ganchoradkov · 2025-02-20T09:17:20Z

Description

Please include a brief summary of the change.

Type of change

Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

Code in this PR is covered by automated tests (Unit tests, E2E tests)
My changes generate no new warnings
I have reviewed my own code
I have filled out all required sections
I have tested my changes on the preview link
Approver of this PR confirms that the changes are tested on the preview link

changeset-bot · 2025-02-20T09:17:24Z

⚠️ No Changeset found

Latest commit: d27ad8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-02-20T09:17:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 21, 2025 10:02am
appkit-ethers5-bera	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 21, 2025 10:02am
appkit-laboratory	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 21, 2025 10:02am
next-wagmi-solana-bitcoin-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 21, 2025 10:02am

10 Skipped Deployments

Name	Status	Preview	Updated (UTC)
appkit-basic-ep	⬜️ Ignored (Inspect)		Feb 21, 2025 10:02am
appkit-basic-ep-example	⬜️ Ignored (Inspect)		Feb 21, 2025 10:02am
appkit-basic-example	⬜️ Ignored (Inspect)		Feb 21, 2025 10:02am
appkit-basic-sign-client-example	⬜️ Ignored (Inspect)		Feb 21, 2025 10:02am
appkit-basic-up-example	⬜️ Ignored (Inspect)		Feb 21, 2025 10:02am
appkit-nansen-demo	⬜️ Ignored (Inspect)	Visit Preview	Feb 21, 2025 10:02am
appkit-vue-solana	⬜️ Ignored (Inspect)		Feb 21, 2025 10:02am
appkit-wagmi-cdn-example	⬜️ Ignored (Inspect)		Feb 21, 2025 10:02am
ethereum-provider-wagmi-example	⬜️ Ignored (Inspect)	Visit Preview	Feb 21, 2025 10:02am
vue-wagmi-example	⬜️ Ignored (Inspect)		Feb 21, 2025 10:02am

github-actions · 2025-02-20T09:19:53Z

	Warnings
⚠️	File packages/appkit-utils/package.json contains a KEY or SECRET
⚠️	File packages/siwe/package.json contains a KEY or SECRET

Generated by 🚫 dangerJS against d27ad8d

github-actions · 2025-02-20T09:22:08Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	72.28%	23067 / 31911
🔵	Statements	72.28%	23067 / 31911
🔵	Functions	62.18%	1847 / 2970
🔵	Branches	81.04%	3989 / 4922

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/scaffold-ui/src/views/w3m-connecting-wc-view/index.ts	75.35%	66%	72.72%	75.35%	41, 51-52, 80-81, 84-85, 106-107, 121-122, 130-131, 142, 146-149, 154, 158, 175, 179-193

Generated in workflow #9726 for commit d27ad8d by the Vitest Coverage Report Action

# Conflicts: # pnpm-lock.yaml

socket-security · 2025-02-20T13:07:26Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@radix-ui/[email protected]	None	`+6`	226 kB	chancestrickland

View full report↗︎

# Conflicts: # pnpm-lock.yaml

tomiir · 2025-02-21T09:58:19Z

packages/scaffold-ui/src/views/w3m-connecting-wc-view/index.ts

-    this.interval = setInterval(
-      this.initializeConnection.bind(this),
-      ConstantsUtil.TEN_SEC_MS
-    ) as unknown as NodeJS.Timeout
-  }


tomiir · 2025-02-21T09:58:31Z

packages/scaffold-ui/src/views/w3m-connecting-wc-view/index.ts

@@ -80,13 +67,9 @@ export class W3mConnectingWcView extends LitElement {
        properties: { message: (error as BaseError)?.message ?? 'Unknown' }
      })
      ConnectionController.setWcError(true)
-      if (CoreHelperUtil.isAllowedRetry(this.lastRetry)) {


do we still need this util? can we remove?

seems isAllowedRetry is also used in AccountController

tomiir · 2025-02-21T09:59:00Z

packages/scaffold-ui/src/views/w3m-connecting-wc-view/index.ts

-      } else {
-        SnackController.showError((error as BaseError).message ?? 'Connection error')
-      }
+      SnackController.showError((error as BaseError).message ?? 'Connection error')


this is no longer looped into reconnecting right? Just triple checking there won't be popups going crazy if a network issue happens and we enter a retry loop

nope, when await ConnectionController.connectWalletConnect() rejects for whatever reason

rejected by the user

proposal expired

the router redirects back to wallet list and thats all

chore: test 2.18.1-canary-ws-2

6dfc472

vercel bot deployed to Preview – appkit-ethers5-bera February 20, 2025 09:20 View deployment

vercel bot deployed to Preview – next-wagmi-solana-bitcoin-example February 20, 2025 09:20 View deployment

vercel bot had a problem deploying to Preview – appkit-laboratory February 20, 2025 09:24 Failure

vercel bot deployed to Preview – appkit-demo February 20, 2025 09:24 View deployment

fix: type

8ac802f

vercel bot deployed to Preview – appkit-ethers5-bera February 20, 2025 09:30 View deployment

vercel bot deployed to Preview – next-wagmi-solana-bitcoin-example February 20, 2025 09:31 View deployment

vercel bot had a problem deploying to Preview – appkit-laboratory February 20, 2025 09:34 Failure

vercel bot deployed to Preview – appkit-demo February 20, 2025 09:35 View deployment

ganchoradkov added 2 commits February 20, 2025 15:04

chore: revert type

c9ee76f

Merge branch 'main' into chore/test-2.18.1-canary-ws-2

a5eb34a

# Conflicts: # pnpm-lock.yaml

chore: ts-node

6799642

vercel bot deployed to Preview – appkit-ethers5-bera February 20, 2025 13:15 View deployment

vercel bot deployed to Preview – appkit-laboratory February 20, 2025 13:18 View deployment

vercel bot deployed to Preview – next-wagmi-solana-bitcoin-example February 20, 2025 13:19 View deployment

vercel bot deployed to Preview – appkit-demo February 20, 2025 13:20 View deployment

chore: updates canary

615b157

vercel bot deployed to Preview – appkit-ethers5-bera February 21, 2025 09:11 View deployment

vercel bot deployed to Preview – next-wagmi-solana-bitcoin-example February 21, 2025 09:12 View deployment

vercel bot deployed to Preview – appkit-demo February 21, 2025 09:13 View deployment

vercel bot deployed to Preview – appkit-laboratory February 21, 2025 09:17 View deployment

ganchoradkov added 2 commits February 21, 2025 11:29

Merge branch 'main' into chore/test-2.18.1-canary-ws-2

2db53db

# Conflicts: # pnpm-lock.yaml

refactor: scrap auto reconnect

d27ad8d

vercel bot deployed to Preview – appkit-ethers5-bera February 21, 2025 09:56 View deployment

vercel bot deployed to Preview – next-wagmi-solana-bitcoin-example February 21, 2025 09:57 View deployment

vercel bot deployed to Preview – appkit-demo February 21, 2025 09:58 View deployment

tomiir reviewed Feb 21, 2025

View reviewed changes

vercel bot deployed to Preview – appkit-laboratory February 21, 2025 10:02 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: test `2.18.1-canary-ws-2` #3885

chore: test `2.18.1-canary-ws-2` #3885

ganchoradkov commented Feb 20, 2025

changeset-bot bot commented Feb 20, 2025 •

edited

Loading

vercel bot commented Feb 20, 2025 •

edited

Loading

github-actions bot commented Feb 20, 2025 •

edited

Loading

github-actions bot commented Feb 20, 2025 •

edited

Loading

socket-security bot commented Feb 20, 2025 •

edited

Loading

tomiir Feb 21, 2025

tomiir Feb 21, 2025

ganchoradkov Feb 21, 2025

tomiir Feb 21, 2025

ganchoradkov Feb 21, 2025 •

edited

Loading

chore: test 2.18.1-canary-ws-2 #3885

Are you sure you want to change the base?

chore: test 2.18.1-canary-ws-2 #3885

Conversation

ganchoradkov commented Feb 20, 2025

Description

Type of change

Associated Issues

Showcase (Optional)

Checklist

changeset-bot bot commented Feb 20, 2025 • edited Loading

⚠️ No Changeset found

vercel bot commented Feb 20, 2025 • edited Loading

github-actions bot commented Feb 20, 2025 • edited Loading

github-actions bot commented Feb 20, 2025 • edited Loading

Coverage Report

socket-security bot commented Feb 20, 2025 • edited Loading

tomiir Feb 21, 2025

Choose a reason for hiding this comment

tomiir Feb 21, 2025

Choose a reason for hiding this comment

ganchoradkov Feb 21, 2025

Choose a reason for hiding this comment

tomiir Feb 21, 2025

Choose a reason for hiding this comment

ganchoradkov Feb 21, 2025 • edited Loading

Choose a reason for hiding this comment

chore: test `2.18.1-canary-ws-2` #3885

chore: test `2.18.1-canary-ws-2` #3885

changeset-bot bot commented Feb 20, 2025 •

edited

Loading

vercel bot commented Feb 20, 2025 •

edited

Loading

github-actions bot commented Feb 20, 2025 •

edited

Loading

github-actions bot commented Feb 20, 2025 •

edited

Loading

socket-security bot commented Feb 20, 2025 •

edited

Loading

ganchoradkov Feb 21, 2025 •

edited

Loading