feat: add generic bumpVersions option #34023
Open
+656
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/config/options/index.ts # lib/workers/repository/update/branch/get-updated.ts
viceice
reviewed
Feb 4, 2025
| }); | ||
|
|
||
| afterEach(() => { | ||
| jest.spyOn(templates, 'compile').mockRestore(); |
There was a problem hiding this comment.
are you sure Jest.spyOn will reuse the last spy? 🤔 I thought it always created a new spy.
There was a problem hiding this comment.
This seems to be the case. If I remove this line all tests after the ones which make of jest.spyOn will fail.
| let newVersion: string | null = null; | ||
| try { | ||
| const bumpType = compile(config.bumpType, branchConfig); | ||
| newVersion = inc(version, bumpType as ReleaseType); |
There was a problem hiding this comment.
we should document that only semver is supported
There was a problem hiding this comment.
This documented here
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implements bumpVersions which leans the semantics of our custom managers
Context
Closes #28045
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
https://github.com/secustor/renovate-bump-versions