-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dev container and tests #19
Conversation
@kjaymiller I think render-engine is not compatible with python 3.9 😄
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment but this looks good. Free to merge!
@@ -0,0 +1,5 @@ | |||
ARG IMAGE="python:3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not 3.13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we did discuss this before it was not available at the time of our discussion.
let me check if it's available now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's available now
https://github.com/devcontainers/images/tree/main/src/python
let me test it tonight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are lying the only available 3.13 is dev-3.13.
let's keep 3.12 until they release a stable 3.13
See:
https://mcr.microsoft.com/v2/vscode/devcontainers/python/tags/list
This PR adds DevContainer support following our render-engine/render_engine configuration in addition to setting up testing for the site generation with Cookiecutter and site build with render-engine-cli.
fix #18
fix #10