Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify NodeTypeResolver #6728

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Simplify NodeTypeResolver #6728

merged 2 commits into from
Feb 10, 2025

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Feb 10, 2025

since AccessoryNonEmptyStringTypeCorrector only works on IntersectionType, it does not make sense to call into it when a UnionType is provided

@staabm staabm marked this pull request as ready for review February 10, 2025 13:43
@samsonasik
Copy link
Member

Let's give it a try, thank you @staabm

@samsonasik samsonasik merged commit 50f9d87 into rectorphp:main Feb 10, 2025
44 checks passed
@staabm staabm deleted the simple branch February 10, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @samsonasik