Type hint array reduce closure

[peterfox]

Changes

• Adds AddClosureParamTypeForArrayReduceRector rule
• Adds tests for AddClosureParamTypeForArrayReduceRector
• Adds to the type dec config:
  • AddClosureParamTypeForArrayReduceRector
  • AddClosureParamTypeForArrayMapRector

Why

This rule is following in the path of #6377 that performed additional type hinting array function calls that use closures. This covers type hinting the items of the array and type hinting the carry.

$array = ['a', 'b', 'c'];
-array_reduce($array, function ($carry, $item) {
+array_reduce($array, function (string $carry, string $item) {
    return $carry . $item;
});

[TomasVotruba]

Looks good 👍

Could you add it to type declaration set?

[peterfox]

Thanks @TomasVotruba I've added it to the config but also added the array map rule as well as it wasn't added previously I believe.

[TomasVotruba]

Thank you 😊

[samsonasik]

@peterfox it seems buggy on nullable object on 2nd param

 Argument #2 ($someParam) must be of type SomeInterface, null given

cause TypeError, I will check if that resolvable.

[samsonasik]

I see, the issue is it read from docblock type as well, which unreliable, per @staabm review at #6377 (comment) , this rule is similar risky, this should not be part of type declaration set, and should be manually added when needed, @peterfox could you create new PR to undo register from type declaration set? Thank you.

[samsonasik]

@staabm @peterfox I created new PR to unregister it, this needs to be registered manually due to docblock type usage

• [TypeDeclaration] Unregister AddClosureParamTypeForArrayMapRector and AddClosureParamTypeForArrayReduceRector due to may read from docblock #6727