[Renaming] Handle crash on assign on for loop on RenameFunctionRector (…

…#6730) * [Renaming] Handle crash on for loop on RenameFunctionRector * Fix * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <[email protected]>
rectorphp · Feb 11, 2025 · 8efb34e · 8efb34e
1 parent 36f2d21
commit 8efb34e
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 0 deletions.
diff --git a/rules-tests/Renaming/Rector/FuncCall/RenameFunctionRector/Fixture/in_for.php.inc b/rules-tests/Renaming/Rector/FuncCall/RenameFunctionRector/Fixture/in_for.php.inc
@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\Renaming\Rector\FuncCall\RenameFunctionRector\Fixture;
+
+class InFor {
+    function process($file) {
+		for ($i=0;$n=sizeof($files),$i<$n;$i++) {
+			$products_image_name = $files[$i]['text'];
+		}
+	}
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Renaming\Rector\FuncCall\RenameFunctionRector\Fixture;
+
+class InFor {
+    function process($file) {
+		for ($i=0;$n=count($files),$i<$n;$i++) {
+			$products_image_name = $files[$i]['text'];
+		}
+	}
+}
+
+?>
diff --git a/rules-tests/Renaming/Rector/FuncCall/RenameFunctionRector/config/configured_rule.php b/rules-tests/Renaming/Rector/FuncCall/RenameFunctionRector/config/configured_rule.php
@@ -11,5 +11,6 @@
             'view' => 'Laravel\Templating\render',
             'sprintf' => 'Safe\sprintf',
             'abc2' => 'abc',
+            'sizeof' => 'count',
         ]);
 };
diff --git a/src/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php b/src/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php
@@ -285,6 +285,10 @@ public function processNodes(
                     if ($expr instanceof BinaryOp) {
                         $this->processBinaryOp($expr, $mutatingScope);
                     }
+
+                    if ($expr instanceof Assign) {
+                        $this->processAssign($expr, $mutatingScope);
+                    }
                 }
 
                 return;