-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow output files to another directory #11
base: master
Are you sure you want to change the base?
Conversation
echo "and in this case, it will treat this directory as root path then perform an" | ||
echo "unattended installation to this directory." | ||
echo | ||
echo "Usually, you just call the script without any parameters and it will guide you" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Are the extraneous spaces sprinkled through the sentences made in order to give the appearance of the displayed text to be "justified" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Shoud it use another layout scheme?
@@ -171,13 +171,13 @@ echo "Using CXXFLAGS=\"$CXXFLAGS\"" | |||
echo | |||
|
|||
if $rs_process_cpucount; then | |||
rs_do_command $CC -s -o "$rs_prefixdir/bin/cpucount" "$rs_scriptdir/tools/cpucount.c" | |||
rs_do_command $CC $CFLAGS $LDFLAGS -s -o "$rs_prefixdir/bin/cpucount" "$rs_scriptdir/tools/cpucount.c" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CFLAGS
and LDFLAGS
are exported, so they should be picked up by the host compiler anyway.
Apart from that, you can't just pass LDFLAGS
to the C compiler.
Hey @chirsz-ever! Thanks for your PR.
|
The two directories are opensource software building system's convention (in my opinion). Autotools has This PR is originly for writing a arch package, and I found it need some untidy hack. The main problem is that the I will do a rebase to fix these problems after #15 being merged. Another problem is that the repeated scripts is too much, including |
This is especially convenient for build a software package for package managers.