Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: support React19 & drop React 16,17 support #915

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat!: support React19 & drop React 16,17 support #915

wants to merge 2 commits into from
+63 −104

Conversation

koba04
Copy link
Member

@koba04 koba04 commented Dec 24, 2024 •
edited
Loading

This only updates CI settings and tests. react-transition-group seems to work with React 19 without any updates

@ddtch
Copy link

ddtch commented Jan 8, 2025

someone please pay attention to this PR

@jquense
Copy link
Collaborator

jquense commented Jan 9, 2025

its in draft and not passing CI @ddtch what do you want us to pay attention to??

@koba04 lmk when this is updated to pass CI

koba04
koba04 commented Jan 10, 2025
View reviewed changes
test/Transition-test.js
@@ -197,35 +196,6 @@ describe('Transition', () => {
});
});

it('should use `React.findDOMNode` when `nodeRef` is not provided', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to skip it conditionally based on React version

@koba04
Copy link
Member Author

koba04 commented Jan 10, 2025

@jquense
Yeah, CI fails are caused because of old dependencies and the Node version, and react-transition-group works with React v19 as long as we use nodeRef, so I think this doesn't block anything.

I'd say we should update our build settings , outdated dependencies and documentation system before updating React version.

@jquense
Copy link
Collaborator

jquense commented Jan 10, 2025

you wanna do it?

@koba04
Copy link
Member Author

koba04 commented Jan 11, 2025

Yeah, I'll do it when I have time, but it would be helpful someone takes that.

The documentation also depends on PropTypes, which was removed in v19, so it would be better to update the documentation as well.
(Keeping PropTypes won't have any issues, it's just ignored, so this isn't a requirement)

https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-deprecated-react-apis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koba04 @ddtch @jquense