Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM-8350 Introduce InterfaceDefinition and update ClassDefinition accordingly #1051

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

a-ctor
Copy link
Contributor

@a-ctor a-ctor commented Mar 12, 2024

@a-ctor a-ctor requested a review from MichaelKetting March 12, 2024 11:30
@a-ctor a-ctor self-assigned this Mar 12, 2024
Copy link
Member

@MichaelKetting MichaelKetting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review, found some parameter namings in the first couple of files. don't know how many more there are that should be optimized to add the relevant semantics

Comment on lines +306 to +308
private IRelationEndPointDefinition GetRelationEndPointDefinition (Type type, string shortPropertyName)
{
return Configuration.GetTypeDefinition(classType).GetRelationEndPointDefinition(classType.FullName + "." + shortPropertyName);
return Configuration.GetTypeDefinition(type).GetRelationEndPointDefinition(type.FullName + "." + shortPropertyName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better naming, perhaps declaringType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants