-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RM-8350 Introduce InterfaceDefinition and update ClassDefinition accordingly #1051
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial review, found some parameter namings in the first couple of files. don't know how many more there are that should be optimized to add the relevant semantics
...Security.UnitTests/SecurityClientTransactionExtensionTests/PropertyDefinitionObjectMother.cs
Outdated
Show resolved
Hide resolved
private IRelationEndPointDefinition GetRelationEndPointDefinition (Type type, string shortPropertyName) | ||
{ | ||
return Configuration.GetTypeDefinition(classType).GetRelationEndPointDefinition(classType.FullName + "." + shortPropertyName); | ||
return Configuration.GetTypeDefinition(type).GetRelationEndPointDefinition(type.FullName + "." + shortPropertyName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better naming, perhaps declaringType
...ement/RelationEndPoints/RealObjectEndPoints/UnsynchronizedRealObjectEndPointSyncStateTest.cs
Outdated
Show resolved
Hide resolved
…orageClassValidationRuleTest
d221533
to
147fb1d
Compare
https://re-motion.atlassian.net/browse/RM-8350