[Examples] Fix colors in lighting shaders #4482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small regression with the lighting example/shader from previous versions with the new 5.5 example,
5.0 used meshes since the batch did not support normals. This meant that the tint was passed to the shader as the 'colDiffuse' uniform.
uses shapes, since the batch system does now support normals. Shapes do't set colDiffuse from the tint, they apply the tint as vertex colors.
The example lighting fragment shader does not use the fragColor, only colDiffuse, so this means that the tint is now ignored where it was not before.
This PR fixes the example lighting shaders to use both frag and diffuse colors so they work with shapes and meshes.