[build]: Replace fatal errors with conditional warnings for Clipboard Image Support
#4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen TARGET_PLATFORM is PLATFORM_DESKTOP_GFLW
…hen TARGET_PLATFORM is PLATFORM_DESKTOP_GFLW
…n index as in SDL2
…LIPBOARD_IMAGE necessary support detection
evertonse
changed the title
errors with conditional warnings for Clipboard Image Support*
evertonse
changed the title
errors with conditional warnings for Clipboard Image Support*errors with conditional warnings for Clipboard Image Support
evertonse
changed the title
errors with conditional warnings for Clipboard Image Supporterrors with conditional warnings for Clipboard Image Support
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+531
to
+534
| // Not needed because `rtexture.c` will automatically defined STBI_REQUIRED when any SUPPORT_FILEFORMAT_* is defined. | ||
| // #if !defined(STBI_REQUIRED) | ||
| // #pragma message ("Warning: "STBI_REQUIRED is not defined, that means we can't load images from clipbard" | ||
| // #endif |
Check notice
Code scanning / CodeQL
Commented-out code Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4459
Conditional compilation warnings instead of warnings to inform developers about the necessary dependencies when enabling clipboard image support (e.g. SUPPORT_MODULE_RTEXTURES, specific image formats , etc ...).
This allows for more flexible configuration while still alerting users, although subtely.