Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Resyntax fixes #456

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Automated Resyntax fixes #456

merged 1 commit into from
Oct 30, 2024

Commits on Oct 30, 2024

  1. Automated Resyntax fixes

    This is an automated change generated by Resyntax.
    
    #### Pass 1
    
    Applied 1 fix to [`scribble-lib/scribble/doclang2.rkt`](../blob/HEAD/scribble-lib/scribble/doclang2.rkt)
    
      * Line 6, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.
    
    Applied 1 fix to [`scribble-lib/scribble/valid-blueboxes-info.rkt`](../blob/HEAD/scribble-lib/scribble/valid-blueboxes-info.rkt)
    
      * Line 5, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.
    
    Applied 3 fixes to [`scribble-lib/scribble/render.rkt`](../blob/HEAD/scribble-lib/scribble/render.rkt)
    
      * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.
      * Line 11, `provide/contract-to-contract-out`: The `provide/contract` form is a legacy form made obsolete by `contract-out`.
      * Line 54, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
    
    Applied 1 fix to [`scribble-lib/scribble/pdf-render.rkt`](../blob/HEAD/scribble-lib/scribble/pdf-render.rkt)
    
      * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.
    
    Applied 1 fix to [`scribble-lib/scribble/latex-properties.rkt`](../blob/HEAD/scribble-lib/scribble/latex-properties.rkt)
    
      * Line 2, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.
    
    Applied 1 fix to [`scribble-lib/scribble/comment-reader.rkt`](../blob/HEAD/scribble-lib/scribble/comment-reader.rkt)
    
      * Line 36, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
    
    Applied 4 fixes to [`scribble-lib/scribble/racket.rkt`](../blob/HEAD/scribble-lib/scribble/racket.rkt)
    
      * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.
      * Line 477, `if-else-false-to-and`: This `if` expression can be refactored to an equivalent expression using `and`.
      * Line 507, `map-to-for`: This `map` operation can be replaced with a `for/list` loop.
      * Line 740, `if-x-else-x-to-and`: This conditional expression can be replaced with a simpler, equivalent expression.
    
    Applied 7 fixes to [`scribble-lib/scribble/struct.rkt`](../blob/HEAD/scribble-lib/scribble/struct.rkt)
    
      * Line 2, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.
      * Line 50, `map-to-for`: This `map` operation can be replaced with a `for/list` loop.
      * Line 217, `map-to-for`: This `map` operation can be replaced with a `for/list` loop.
      * Line 230, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
      * Line 372, `andmap-to-for/and`: This `andmap` operation can be replaced with a `for/and` loop.
      * Line 387, `if-let-to-cond`: `cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
      * Line 417, `cond-let-to-cond-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
    
    Applied 1 fix to [`scribble-lib/scribble/doclang.rkt`](../blob/HEAD/scribble-lib/scribble/doclang.rkt)
    
      * Line 2, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.
    
    ## Summary
    
    Fixed 20 issues in 9 files.
    
      * Fixed 8 occurrences of `tidy-require`
      * Fixed 3 occurrences of `let-to-define`
      * Fixed 3 occurrences of `map-to-for`
      * Fixed 1 occurrence of `provide/contract-to-contract-out`
      * Fixed 1 occurrence of `if-else-false-to-and`
      * Fixed 1 occurrence of `if-x-else-x-to-and`
      * Fixed 1 occurrence of `andmap-to-for/and`
      * Fixed 1 occurrence of `if-let-to-cond`
      * Fixed 1 occurrence of `cond-let-to-cond-define`
    resyntax-ci[bot] committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1b2cff8 View commit details
    Browse the repository at this point in the history