Automated Resyntax fixes #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This is an automated change generated by Resyntax. #### Pass 1 Applied 1 fix to [`scribble-lib/help/help.rkt`](../blob/HEAD/scribble-lib/help/help.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 3 fixes to [`scribble-lib/help/search.rkt`](../blob/HEAD/scribble-lib/help/search.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 21, `define-let-to-double-define`: This `let` expression can be pulled up into a `define` expression. * Line 50, `if-let-to-cond`: `cond` with internal definitions is preferred over `if` with `let`, to reduce nesting Applied 2 fixes to [`scribble-lib/scribble/lncs/lang.rkt`](../blob/HEAD/scribble-lib/scribble/lncs/lang.rkt) * Line 2, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 100, `if-begin-to-cond`: Using `cond` instead of `if` here makes `begin` unnecessary ## Summary Fixed 6 issues in 3 files. * Fixed 3 occurrences of `tidy-require` * Fixed 1 occurrence of `define-let-to-double-define` * Fixed 1 occurrence of `if-let-to-cond` * Fixed 1 occurrence of `if-begin-to-cond`
mflatt
reviewed
Oct 15, 2024
| (skip sz) | ||
| (when data-desc? | ||
| skip | ||
| 12) |
There was a problem hiding this comment.
Refactoring seems to be highlighting a bug here! I'll look at that separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated change generated by Resyntax.
Pass 1
Applied 1 fix to
scribble-lib/help/help.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 3 fixes to
scribble-lib/help/search.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.define-let-to-double-define: Thisletexpression can be pulled up into adefineexpression.if-let-to-cond:condwith internal definitions is preferred overifwithlet, to reduce nestingApplied 2 fixes to
scribble-lib/scribble/lncs/lang.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.if-begin-to-cond: Usingcondinstead ofifhere makesbeginunnecessarySummary
Fixed 6 issues in 3 files.
tidy-requiredefine-let-to-double-defineif-let-to-condif-begin-to-cond