Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update menus.scrbl #693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

spdegabrielle
Copy link
Member

added context menu items to documentation

added context menu items to documentation
@spdegabrielle
Copy link
Member Author

includes Save Image... as this was added in 8.15

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resyntax analyzed 0 files in this pull request and found no issues.

Copy link
Member

@rfindler rfindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! If you would like me to take it from here, I'm happy to do so. The changes I'd do are the ones mentioned.

@item{@defmenuitem{Save Image...} Save currently selected image to file.}
]

Standard editng functions are also available via the context menu: Undo,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here.

@section{@onscreen{Context menu}}

The following additional menu items may be available when activating the context menu in an
editing panel.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the phrase "editing panel" either. For this one, I think that "either the definitions or interactions window" is probably the right phrase.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you do!

1 Interface Essentials

The DrRacket window has three parts: a row of buttons at the top, two editing panels in the middle, and a status line at the bottom.

image


@section{@onscreen{Context menu}}

The following additional menu items may be available when activating the context menu in an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we use the phrase "context menu" elsewhere in the documentation. In the racket/gui docs, it is called a "popup menu".

I guess a good idea is to look around in the drracket docs and see what term is used and then either change them all or change this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

popup is fine.

I might be tempted to add 'also known as 'context menu' to the racket gui docs - and add an example to the gallery https://docs.racket-lang.org/gui/Widget_Gallery.html

editing panel.

@itemize[

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these items appear in some context and some in others. How about breaking them up into lists based on a description of where they might appear?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it, but I would not worry too much

@item{@defmenuitem{Search in Help Desk for ...} Opens browser and triggers
search of documentation for selected term.}

@item{@defmenuitem{Save Image...} Save currently selected image to file.}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it saves the one you click on, not the selected one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

]

Standard editng functions are also available via the context menu: Undo,
Redo, copy, cut, paste, Select All, and Select All.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably also be itemized.

@spdegabrielle
Copy link
Member Author

Thanks for doing this! If you would like me to take it from here, I'm happy to do so. The changes I'd do are the ones mentioned.

Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants