Skip to content

Commit

Permalink
update cran comments for resubmission
Browse files Browse the repository at this point in the history
  • Loading branch information
tylerlittlefield committed Aug 13, 2020
1 parent b328e90 commit cc03337
Show file tree
Hide file tree
Showing 5 changed files with 40 additions and 34 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@
^\.github$
^data-raw$
^cran-comments\.md$
^CRAN-RELEASE$
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ RoxygenNote: 7.1.1
Imports:
shiny,
htmltools
URL: https://github.com/tyluRp/hover
BugReports: https://github.com/tyluRp/hover/issues
URL: https://github.com/r4fun/hover
BugReports: https://github.com/r4fun/hover/issues
Suggests:
testthat
Depends:
Expand Down
4 changes: 2 additions & 2 deletions README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ knitr::opts_chunk$set(
# hover

<!-- badges: start -->
[![R build status](https://github.com/tyluRp/hover/workflows/R-CMD-check/badge.svg)](https://github.com/tyluRp/hover/actions)
[![Codecov test coverage](https://codecov.io/gh/tyluRp/hover/branch/master/graph/badge.svg)](https://codecov.io/gh/tyluRp/hover?branch=master)
[![R build status](https://github.com/r4fun/hover/workflows/R-CMD-check/badge.svg)](https://github.com/r4fun/hover/actions)
[![Codecov test coverage](https://codecov.io/gh/r4fun/hover/branch/master/graph/badge.svg)](https://codecov.io/gh/r4fun/hover?branch=master)
<!-- badges: end -->

The goal of hover is to add animations to `shiny::actionButton`, `shiny::downloadButton`, and `shiny::icon` using [Hover.css](https://github.com/IanLunn/Hover).
Expand Down
60 changes: 30 additions & 30 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,64 +1,64 @@

<!-- README.md is generated from README.Rmd. Please edit that file -->

# hover
hover
=====

<!-- badges: start -->

[![R build
status](https://github.com/tyluRp/hover/workflows/R-CMD-check/badge.svg)](https://github.com/tyluRp/hover/actions)
status](https://github.com/r4fun/hover/workflows/R-CMD-check/badge.svg)](https://github.com/r4fun/hover/actions)
[![Codecov test
coverage](https://codecov.io/gh/tyluRp/hover/branch/master/graph/badge.svg)](https://codecov.io/gh/tyluRp/hover?branch=master)
coverage](https://codecov.io/gh/r4fun/hover/branch/master/graph/badge.svg)](https://codecov.io/gh/r4fun/hover?branch=master)
<!-- badges: end -->

The goal of hover is to add animations to `shiny::actionButton`,
`shiny::downloadButton`, and `shiny::icon` using
[Hover.css](https://github.com/IanLunn/Hover).

## Installation
Installation
------------

You can install the development version of hover from GitHub with:

``` r
# install.packages("devtools")
devtools::install_github("r4fun/hover")
```
# install.packages("devtools")
devtools::install_github("r4fun/hover")

## Example
Example
-------

Animate a button and icon by providing the animation name:

``` r
library(shiny)
library(hover)
library(shiny)
library(hover)

ui <- fluidPage(
use_hover(),
hover_action_button(
inputId = "btn",
label = "hello hover!",
icon = icon("refresh"),
button_animation = "rotate",
icon_animation = "spin"
)
)
ui <- fluidPage(
use_hover(),
hover_action_button(
inputId = "btn",
label = "hello hover!",
icon = icon("refresh"),
button_animation = "rotate",
icon_animation = "spin"
)
)

server <- function(input, output, session) {

}
server <- function(input, output, session) {
}

shinyApp(ui, server)
```
shinyApp(ui, server)

The `hover` package essentially takes the `shiny::actionButton` source
code and applies the necessary Hover.css classes to make things move.

## Acknowledgements
Acknowledgements
----------------

This package was built using the following tools:

- [Hover.css](https://github.com/IanLunn/Hover), the underlying CSS
- [shiny](https://github.com/rstudio/shiny), the source code for
- [Hover.css](https://github.com/IanLunn/Hover), the underlying CSS
- [shiny](https://github.com/rstudio/shiny), the source code for
`hover_button`

Without these, this package wouldn’t have been possible.
5 changes: 5 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## Resubmission
This is a resubmission. In this version I have:

*Resolved broken links.

## Test environments
* local R installation, R 4.0.2
* ubuntu 16.04 (on travis-ci), R 4.0.2
Expand Down

0 comments on commit cc03337

Please sign in to comment.