Source: GCP Pub/Sub #622
Open
Source: GCP Pub/Sub #622
+480
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwaramadze
reviewed
Nov 13, 2024
gwaramadze
reviewed
Nov 13, 2024
gwaramadze
reviewed
Nov 13, 2024
gwaramadze
reviewed
Nov 13, 2024
daniil-quix
reviewed
Nov 13, 2024
daniil-quix
reviewed
Nov 13, 2024
|
Outstanding additions like license, optional install are included in Remy's PR. |
daniil-quix
reviewed
Nov 14, 2024
quixstreams/sources/community/pubsub/components/pubsub_consumer.py
Outdated
Show resolved
Hide resolved
daniil-quix
reviewed
Nov 14, 2024
quixstreams/sources/community/pubsub/components/pubsub_consumer.py
Outdated
Show resolved
Hide resolved
daniil-quix
reviewed
Nov 14, 2024
quixstreams/sources/community/pubsub/components/pubsub_consumer.py
Outdated
Show resolved
Hide resolved
daniil-quix
reviewed
Nov 14, 2024
quixstreams/sources/community/pubsub/components/pubsub_consumer.py
Outdated
Show resolved
Hide resolved
daniil-quix
reviewed
Nov 14, 2024
quixstreams/sources/community/pubsub/components/pubsub_consumer.py
Outdated
Show resolved
Hide resolved
daniil-quix
reviewed
Nov 14, 2024
gwaramadze
reviewed
Nov 14, 2024
tim-quix
force-pushed
the
source/gcp-pubsub
branch
from
0526d6b
to
c67c819
Compare
daniil-quix
previously approved these changes
Nov 14, 2024
…rather than whole message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also experimented with a way to do imports while still enabling type referencing and not include them as part of our libraries optional installs (it's nothing fancy, but figure it might be useful to establish a pattern)