Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing use_cc_toolchain symbol #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

svetlyak40wt
Copy link

Without this fix, I receive this error:

ERROR: Traceback (most recent call last):
	File "/private/var/tmp/_bazel_art/c8a5b510bf75c3e5cd5fe54b17c3c02f/external/bazelisp/rules.bzl", line 21, column 67, in <toplevel>
		load("@rules_cc//cc:find_cc_toolchain.bzl", "find_cc_toolchain", "use_cc_toolchain")
Error: file '@rules_cc//cc:find_cc_toolchain.bzl' does not contain symbol 'use_cc_toolchain' (did you mean 'find_cc_toolchain'?)
ERROR: Skipping '//foobar:foobar': error loading package 'foobar': initialization of module 'rules.bzl' failed
WARNING: Target pattern parsing failed.
ERROR: error loading package 'foobar': initialization of module 'rules.bzl' failed
INFO: Elapsed time: 4.436s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
    currently loading: foobar

Without this fix, I receive this error:

```
ERROR: Traceback (most recent call last):
	File "/private/var/tmp/_bazel_art/c8a5b510bf75c3e5cd5fe54b17c3c02f/external/bazelisp/rules.bzl", line 21, column 67, in <toplevel>
		load("@rules_cc//cc:find_cc_toolchain.bzl", "find_cc_toolchain", "use_cc_toolchain")
Error: file '@rules_cc//cc:find_cc_toolchain.bzl' does not contain symbol 'use_cc_toolchain' (did you mean 'find_cc_toolchain'?)
ERROR: Skipping '//foobar:foobar': error loading package 'foobar': initialization of module 'rules.bzl' failed
WARNING: Target pattern parsing failed.
ERROR: error loading package 'foobar': initialization of module 'rules.bzl' failed
INFO: Elapsed time: 4.436s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
    currently loading: foobar
```
@egao1980
Copy link

I think we'd need skylib too:

diff --git a/repositories.bzl b/repositories.bzl
index bf66c45..e3127de 100644
--- a/repositories.bzl
+++ b/repositories.bzl
@@ -21,7 +21,7 @@ def bazelisp_repositories():
         name = "bazel_skylib",
         remote = "https://github.com/bazelbuild/bazel-skylib.git",
         # tag = "1.0.3",
-        commit = "2ec2e6d715e993d96ad6222770805b5bd25399ae",
+        commit = "a501641daebdce8601ee6bbc6b5d177c688d3517",
         shallow_since = "1598536904 -0400",
     )
 
@@ -38,7 +38,7 @@ def bazelisp_repositories():
         git_repository,
         name = "rules_cc",
         remote = "https://github.com/bazelbuild/rules_cc.git",
-        commit = "b1c40e1de81913a3c40e5948f78719c28152486d",
+        commit = "2f8c04c04462ab83c545ab14c0da68c3b4c96191",
         shallow_since = "1605101351 -0800",
     )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants