Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebUI: Use event delegation to handle common table events #21829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WebUI: Use event delegation to handle common table events #21829

wants to merge 1 commit into from

Conversation

skomerko
Copy link
Contributor

Event delegation is now used to handle basic table events.
2 minor fixes were added to match GUI behavior:

  • Clicking on the table body deselects everything
  • Table rows are now scrolled into view when using up/down arrows

skomerko
skomerko commented Nov 13, 2024
View reviewed changes
src/webui/www/private/scripts/dynamicTable.js
}
});
}
setupCommonEvents: () => {}
Copy link
Contributor Author

@skomerko skomerko Nov 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bulk rename table does not make any use of common events from what I can tell.

@xavier2k6 xavier2k6 added the WebUI WebUI-related issues/changes label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skomerko @xavier2k6